ponyc icon indicating copy to clipboard operation
ponyc copied to clipboard

String.f32 and f64 should be implemented in Pony.

Open jemc opened this issue 9 years ago • 5 comments

Currently String.f32 and f64 use the strtof FFI call internally.

As discussed on the sync call, it would be desirable for us to implement this in pure Pony instead of relying on the C call for something we can do ourselves in a more transparent, debuggable way.

This change should have no impact on the user, so it doesn't need an RFC - it just needs someone to step up and do the implementation.

jemc avatar Nov 30 '16 21:11 jemc

Hey @jemc, I would like to carry out this task

laucer avatar Dec 23 '16 07:12 laucer

@laucer - Thanks for stepping up!

I've sent you an invite to the ponylang organization, so that you can be assigned to this issue ticket after you accept the invitation.

jemc avatar Dec 23 '16 18:12 jemc

@laucer - Thanks for accepting the invite - I've assigned you to this ticket. Let us know if you have any questions about it.

Thanks!

jemc avatar Dec 24 '16 16:12 jemc

it means we can close #1445 as "won't do", as I understand this ticket solves problem with calling strtof

kcrimson avatar Feb 03 '17 10:02 kcrimson

@kcrimson - I left it open, as I was anticipating that this ticket might take a long time to complete, and the fix suggested in #1445 is pretty trivial. The way I see it, #1445 fixes the immediate problem of not using cstring as we should be, and this ticket is a more long-term effort to replace the strtof call entirely.

jemc avatar Feb 03 '17 20:02 jemc