pony-stable icon indicating copy to clipboard operation
pony-stable copied to clipboard

Rename pony-stable to tack

Open SeanTAllen opened this issue 7 years ago • 7 comments

This is a PR I am opening to get the work started on this. So far, it includes changing references to bundle.json to tack.json.

@dipinhora do you have time to add changes to the release process to this PR? are there changes with external services that need to be made? i know the pony-stable forumula will need to be changed.

SeanTAllen avatar Oct 14 '18 13:10 SeanTAllen

I've left the name "bundle" in the code but the file is tack.json given that you can have a "tack bundle" as a term with horses. This seems reasonable. The tack.json file defines your bundle of dependencies. However, I'm also open to saying "no, things like _BundleLocator need to be renamed as its confusing otherwise". If that were the case _TackLocator? That seems slightly od to me as the program itself will be called tack.

Thoughts @jemc?

SeanTAllen avatar Oct 14 '18 14:10 SeanTAllen

Agreed about leaving internal use of the term "bundle".

jemc avatar Nov 02 '18 02:11 jemc

@dipinhora do you have time to walk me through the mechanics of the rename for COPR etc?

SeanTAllen avatar Feb 12 '19 17:02 SeanTAllen

@SeanTAllen I'm not sure I have the answers re: COPR, deb packaging, appimage, etc. I don't know if a rename would be sufficient or if it would be better to create a new package for tack. It's a decision that would need to be made along with some others. Should the old pony-stable packages remain for backwards compatibility (without getting new versions added)? Should the pony-stable package remain and become a virtual package that installs tack after the change? There are likely other things to consider and think through and make decisions about.

Once the decisions regarding the package management considerations to the rename have been figured out and made, I can help with figuring out the technical side of things as time permits if needed (note: I'm not an expert on RPM/DEB/etc packaging and would likely be relying on docs and google to figure things out so asking me may or may not be better than trying to figure things out yourself).

dipinhora avatar Feb 15 '19 20:02 dipinhora

Rebased onto master.

SeanTAllen avatar Nov 13 '19 00:11 SeanTAllen

CI in GH is a little confused right now.

We have failing tests after the rebase. Someone (probably me) can look into it. I'm going to be figuring out the Windows + @cloudsmith story first.

SeanTAllen avatar Nov 13 '19 00:11 SeanTAllen

I'm going to remove bintray as part of this PR.

SeanTAllen avatar Nov 13 '19 01:11 SeanTAllen