Bulletproof shell scripts
We have potential issues when the installation directories contain special characters such as spaces.
http://glu.977617.n3.nabble.com/New-bie-Issue-installing-org-linkedin-glu-packaging-all-5-1-0-td4025931.html
I'm tempted to use the wildcard notation feature to simplify some of the scripts: https://en.wikipedia.org/wiki/Classpath_(Java)#Basic_usage
I'll have to change a lot of scripts and update many lines. I will use arrays since this is the only way to properly preserve space characters in paths for the many java arguments.
After updating a dozen files it seems this is futile since we end up depending on third party shell scripts such as jetty.sh. Changes I make will have to rely on array types to build very long argument lists such as we need for JAVA_OPTIONS. I can give you my changes to setup.sh and tutorial.sh since they are an improvement, but there is no good way to ensure that Glu is deployable if it is under a path with spaces or other special characters.
If you can provide a "fixed" version of jetty.sh with 5.1.0 it is very easy to now "inject" the fix... It simply needs to be checked in under: packaging/org.linkedin.glu.packaging-setup /src/cmdline/resources/config-templates/console-server/@jetty.distribution@/bin/jetty.sh and when running the setup command it will simply override the one built-in with jetty..
Yan
Maybe we can bundle this change with #202 ?