Andrew Hodgkinson

Results 60 comments of Andrew Hodgkinson

No matter what the outcome here, https://github.com/RIPAGlobal/omniauth-azure-activedirectory-v2/pull/10 adds documentation as described above.

@Jureamer For sure, a PR with tests would be really great, thanks - but it would be good if we could also actually get a URL for a Microsoft document...

cjolly's pull request from June 8th is doing the same thing, with a different solution. Your solution is the same as mine. Frustrating that developers are wasting their valuable time...

Bit of a shame to find this pull request from months ago. I encountered exactly the same issue - basically, prototype-ujs at the time of writing is not entirely compatible...

@sdhull Please trying locking Cuprite to 0.15.0 and Ferrum to 0.14.0 in your Gemfile: ```ruby gem 'ferrum', '= 0.14.0' gem 'cuprite', '= 0.15.0' ``` ...as it's possible you're seeing another...

The issue on Ferrum (on my phone and don't have the link handy sorry, will post later) suggests adding option "flatten: false". If that doesn't fix it then you have...

Well the Ferrum issue - since I promised to link to it! - is https://github.com/rubycdp/ferrum/issues/470 but it **does not sound like the fault you have**. I'm not sure _what_ is...

@Jureamer Sorry for the delay here. Just as I was getting around to this (a month late, sigh) some very valid points came up in #33 and I was thinking...

This will go into V3 under the rename `omniauth-entra-id` - to be released soon, I hope

Thanks, merged. I think I see an error where if custom provider is given but tenant name isn't, it used to build an appropriate URL but your updated logic does...