ingress-controller icon indicating copy to clipboard operation
ingress-controller copied to clipboard

Published 20 hours ago • verified publisher icon pomerium

applySettings should return new pb.Settings

Open wasaga opened this issue 1 year ago • 1 comments 

          in fact, we _used to_ merge with current settings, but we don't anymore. as a follow-up we should update the applySettings function to explicitly return a new pb.Settings rather then taking it as an argument, that is a legacy of previous behaviour where it merged changes into it.

Originally posted by @wasaga in https://github.com/pomerium/ingress-controller/pull/811#discussion_r1388419711

wasaga avatar Nov 09 '23 18:11 wasaga