ingress-controller icon indicating copy to clipboard operation
ingress-controller copied to clipboard

[P3] validate Ingress parameter combination

Open wasaga opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe.

Not all combinations of parameters are compatible, i.e.

  1. TCP routes do not support certain annotations such as secure_upstream
  2. prefix_rewrite would only affect routes that have pathType: Prefix
  3. there's likely more

It is relatively easy to make a mistake (i.e. when starting from a template or example), and may be impossible to debug or figure out what is wrong.

We currently only detect certain obviously invalid parameter combinations, and validate the configuration via Envoy.

Describe the solution you'd like

  1. add validation to parameter values
  2. add validation for parameter compatibility
  3. do not reconcile Ingress resources that are incorrect / invalid.

Describe alternatives you've considered

Explain any additional use-cases

Additional context

wasaga avatar May 04 '22 23:05 wasaga