stargazer icon indicating copy to clipboard operation
stargazer copied to clipboard

feat: adaptive layout; various customizations

Open Rongronggg9 opened this issue 2 years ago • 2 comments

Motivation

If the owner name and/or the repo name are too long, the rendered video will be ugly.

https://user-images.githubusercontent.com/15956627/173207995-a82a5807-8445-4dff-b3f3-c293534ce624.mp4

Conclusion

With this PR (along with #7) and appropriate configurations, everything is just perfect! I made some other minor improvements as well.

image

https://user-images.githubusercontent.com/15956627/173209511-cb8e6f78-5155-4769-ba6a-8184dd41624e.mp4

Patch details

  • adaptive layout
  • various customization configurations
    • resolution
    • FPS
    • scale
    • Show/hide stargazers' login names as well as their names
    • Show/hide the repo name in each stargazer card
  • speedup (50%) rendering time by using both CPU cores of GHA hosted runners
  • make the stargazers' names bolded (same as GitHub UI)
  • fix the malformed workflow YAML (the default value of a workflow input must be string, not number)
  • bump package-lock.json to get rid of dependabot security alerts and old lockfile warning from npm

I've tested the patch on multiple different settings.

Rongronggg9 avatar Jun 12 '22 00:06 Rongronggg9

rebased since #7 had been merged.

Rongronggg9 avatar Jun 12 '22 15:06 Rongronggg9

dark mode support would be very nice. also output to gif instead of mp4.

yashash-pugalia avatar Sep 11 '22 08:09 yashash-pugalia

Hi @Rongronggg9, thanks for the PR!

I've just become a co-maintainer of Stargazer, and planning to add many of these features to this project! Rather than parametrize all metadata, I would like to turn it into a template to encourage users to edit the code to change the design.

Since this PR has become stale and makes many changes at once, not all of which I am convinced are holding up, I will not merge it, but still implement some of the best improvements once the template has been converted to TypeScript. Hope you understand!

JonnyBurger avatar Jun 20 '23 07:06 JonnyBurger