git-history Unable to view history in private repos

Unable to view history in private repos

Open russharding opened this issue 5 years ago • 17 comments

When viewing a file from a private repo, I get a "File not found" error.

There are a couple cases here.

Repo is private - "File not found"

Repo is public, open file, make repo private - File opens, files not accessed while repo is public- "File not found"

Feb 20 '19 14:02 russharding

It doesn't show the "log in with GitHub" button?

Feb 20 '19 16:02 pomber

Hey @russharding I can't reproduce this one. If it still happens please reopen the issue with more info.

Feb 21 '19 19:02 pomber

steps_to_reproduce.zip @pomber attached with steps to reproduce, with screen shots.

Feb 21 '19 20:02 russharding

@pomber I don't have rights to reopen this ticket.

Feb 21 '19 20:02 russharding

Thanks, what do you use to open a .mht file? can you export it to another format?

Feb 21 '19 20:02 pomber

steps_to_reproduce.pdf better layout

Feb 21 '19 20:02 russharding

Sorry, I can't see the "File not found" error on any step. Where is it?

Feb 21 '19 21:02 pomber

Glad my recording tool cut off the one part I needed.

Lets try this instead. https://www.youtube.com/watch?v=Pv0yZOKi_-Y&hd=1

Feb 21 '19 21:02 russharding

Oh, ok. Can you try it on an incognito window just in case?

Feb 21 '19 21:02 pomber

Same issue here.

Feb 22 '19 03:02 huanzhang

Are there any security risks to signing in to private repo?

Feb 22 '19 04:02 lacostenycoder

Same result in incognito - https://www.youtube.com/watch?v=AEaSZo-OU4M&hd=1

Feb 22 '19 13:02 russharding

:confused: I'm still not able to reproduce it so I'll need more info. Can you show me the network tab so we can see what request is returning a 404?
Is it possible to add me as a collaborator to that private project so I can test it with the same repo?

Feb 22 '19 18:02 pomber

Are there any security risks to signing in to private repo?

@lacostenycoder see this comment https://github.com/pomber/git-history/issues/15#issuecomment-461962806 The code is only exposed to your browser so it should be safe, but if you really dont want to risk it because the repo is very important, it's safer to use the CLI.

Feb 22 '19 18:02 pomber

@pomber same problem

api.github.com/repos/ response 404