wrap-cli icon indicating copy to clipboard operation
wrap-cli copied to clipboard

CLI version 0.10.4 and 0.10.5 produce `wasm-bindgen` TypeScript artifacts when building Rust Wasm wrap

Open krisbitney opened this issue 2 years ago • 1 comments

Describe the bug CLI versions 0.10.4 and 0.10.5 produce wasm-bindgen TypeScript artifacts when building Rust Wasm wrap. Clearing the docker cache does not fix the issue. The wrappers are still working and can be invoked.

TODO:

  • [x] check if it happens with 0.10.4
  • [x] clear docker cache with docker system prune --all --volumes

Please provide the steps to reproduce and if possible a minimal demo of the problem.

  1. Clone https://github.com/polywrap/wrap-abi-bindgen.git
  2. Checkout branch kris/wrap-0.1
  3. navigate to the implementations/app-typescript directory
  4. In package.json, change the polywrap and @polywrap/schema-parse dependency versions to 0.10.5
  5. run nvm use && yarn && yarn build
  6. The unexpected artifacts can be found in the build folder

Expected behavior All wasm-bindgen should be removed by wasm-snip

Screenshots / logs Screenshot 2023-06-28 at 10 48 21 AM Screenshot 2023-06-28 at 10 49 43 AM Screenshot 2023-06-28 at 10 49 52 AM Screenshot 2023-06-28 at 10 49 59 AM Screenshot 2023-06-28 at 10 50 06 AM

The wrap's Rust dependencies:

[dependencies]
polywrap-wasm-rs = { version = "~0.10.5" }
serde = { version = "1.0", features = ["derive"] }
serde_json = { version = "1.0.97" }
handlebars = { version = "4.3.7" }
lazy_static = { version = "1.4.0" }
regex = { version = "1.8.4" }

Relevant environment details:

  • OS: Mac OS

Additional context I am aware that this also occurred when building the ethers-utils wrap found here: https://github.com/polywrap/ethers/tree/main/wraps/utils

krisbitney avatar Jun 28 '23 15:06 krisbitney

Can confirm that this same thing happens on Ubuntu 20.04.4 LTS, running through WSL.

pileks avatar Jun 29 '23 13:06 pileks