wrap-cli icon indicating copy to clipboard operation
wrap-cli copied to clipboard

Bug: Wrapper fetch using ENS text record fails

Open cbrzn opened this issue 2 years ago • 0 comments

Describe the bug When I try to invoke a wrapper using ENS text record using the browser, it just stays loading forever, not showing any errors

Please provide the steps to reproduce and if possible a minimal demo of the problem.

  • Clone this repository https://github.com/polywrap/safe-demo-app/
  • Checkout to branch cbrzn/upgrade-to-pre.10
  • Comment these three redirects: https://github.com/polywrap/safe-demo-app/blob/cbrzn/upgrade-to-pre.10/src/client-config.ts#L31-L33
  • Run yarn && yarn start
  • Try to add a safe, it should hang forever, without throwing any errors

Expected behavior The execution should work, or should throw an error at least (I think this might be related with how we're not handling errors in URI resolvers)

Additional context

This is where the configuration is being created: https://github.com/polywrap/safe-demo-app/blob/cbrzn/upgrade-to-pre.10/src/client-config.ts#L9 and here is where is being executed https://github.com/polywrap/safe-demo-app/blob/cbrzn/upgrade-to-pre.10/src/components/DeployForm.tsx#L33-L49.

It's worth mentioning that if you dont comment the three redirects mentioned in the steps to reproduce, it will work as expected. This is weird because the we have the same ipfs hashes in ens: image

cbrzn avatar Mar 09 '23 16:03 cbrzn