wrap-cli icon indicating copy to clipboard operation
wrap-cli copied to clipboard

IPFS Plugin - move config into envs + method options

Open pileks opened this issue 3 years ago • 0 comments

Want to complete before merge:

  • [x] Tests for timeouts
    • [x] IPFS
    • [x] IPFS Resolver
  • [x] Determine what to do regarding IPFS Interface fallbackProviders
    • Should we have fallbackProviders be part of the IPFS interface specification? Seems like the answer would be “no”, because this would mean we are assuming that all implementations of the IPFS plugin should use fallback providers.
    • After discussing with @nerfZael we have decided to, for now, move fallbackProviders into the Options type of the Ipfs interface
  • [ ] Determine what to do regarding the naming of skipCheckIfExistsBeforeGetFile in IPFS Resolver Plugin env
    • I’m not a big fan of how I named this, though I can’t come up with a better name… any suggestion is welcome!
  • [ ] See if we would maybe want to switch to a providers system instead of having a provider and fallbackProviders
    • Probably not part of this PR, but wanted to see people’s thoughts.
  • [ ] Should we include Env in IPFS Interface schema?

pileks avatar Jul 21 '22 09:07 pileks