wrap-cli icon indicating copy to clipboard operation
wrap-cli copied to clipboard

Workflows Should Use Polywrap Manifest Best-Practices

Open dOrgJelli opened this issue 3 years ago • 0 comments

Currently the workflow file is being "blindly" parsed & loaded: https://github.com/polywrap/monorepo/blob/4eac9010f4b3cb7cd041854a737bd84e176d816c/packages/cli/src/commands/run.ts#L79-L81

We should follow the best-practices we have put in place for the other Polywrap manifests, by first defining a JSON-Schema here: https://github.com/polywrap/monorepo/tree/origin/packages/manifests/polywrap/formats

This will allow us to use the generated type in core, and automatically validate the input file by using the deserializeWorkflowManifest function that's exported from here for each manifest type: https://github.com/polywrap/monorepo/tree/origin/packages/js/manifests/polywrap/src/formats

dOrgJelli avatar Jul 13 '22 07:07 dOrgJelli