Polypheny-DB icon indicating copy to clipboard operation
Polypheny-DB copied to clipboard

New validation on wildcard was added to AbstractJdbcSource.java,

Open dengjuan0721 opened this issue 11 months ago • 0 comments

Summary

This change introduces a check during the parsing of settings to determine whether the value associated with the "tables" key is a wildcard character "*". If it is, an exception will be thrown. Fixes: #477

Changes

Implemented a validation mechanism within the settings parser that checks for the presence of a wildcard character "*" as the value for the "tables" key. Prior to this change, the parser did not restrict the use of wildcard characters, which could lead to ambiguous or unintended behavior.


Features

Wildcard ‘*’ Validation

Bug Fixes

Adding Data Source Tables containing wildcards '*' breaks schema


Tests

1.use '*' to select tables 截屏2024-03-17 13 34 00 2.web UI prompts 'unable to add 截屏2024-03-17 13 33 49 3.The exception output appears in the console section of the IDE. 截屏2024-03-17 13 31 47


Further Contribution

If this solution is deemed viable, it will be necessary to implement the same validation check across the remaining five implementations. Ensuring this consistency will maintain the protection against using a wildcard character '*' as a table name across the entire codebase, which is critical for the comprehensive resolution of issue #477. 截屏2024-03-17 13 40 34

dengjuan0721 avatar Mar 17 '24 05:03 dengjuan0721