Aaron Li
Aaron Li
Seems good to go
Publishing and verification steps (after build): (1) download the build and verification files (onewallet.zip, and checksums.md5) in a folder (2) unzip onewallet.zip to onewallet folder (just double click the zip...
We should also include https://github.com/harmony-one/chrome-extension-wallet/pull/121 in the next version
The change looks good. Reviewing all code from scratch and testing
Code looks good (checked independent of the diffs)
Hash confirmed. Transfer and Delegate operations are tested. Signing (smart contract call), personal sign (offline), undelegate, and collectreward are not tested yet ``` 9dd83b1e280ac286a73d1dd77d1a630e onewallet.zip f154b1cb14edddb503f0eb206fc02619 onewallet/background.js a977b17761041948fbf5fb078e3516d5 onewallet/content-script.js 56b83367de1bad67f158c51ac140006a...
New changes look good. Also I got hashes ``` f154b1cb14edddb503f0eb206fc02619 onewallet/background.js a977b17761041948fbf5fb078e3516d5 onewallet/content-script.js 56b83367de1bad67f158c51ac140006a onewallet/inject-script.js ce8793e5caccd76ef073947346e533ca onewallet/popup.js 604c6d74953a59aedc1af4c4f0b94e16 onewallet/popup.html ```
okay, hashes are ``` 27271cad9dc90f25a7f2eab2861eab2b onewallet/background.js 156770284f99f8e9019a15f7419c34f5 onewallet/content-script.js c163f7329920e2e512dcfc3e63410711 onewallet/inject-script.js 6fe27b144e95dfd5110067afde96ed54 onewallet/popup.js 604c6d74953a59aedc1af4c4f0b94e16 onewallet/popup.html ```
I think this is ready for a release
merge this? since it is already deployed