maths-rs icon indicating copy to clipboard operation
maths-rs copied to clipboard

Added `smootherstep()`

Open virtualritz opened this issue 1 year ago • 4 comments

I have trimmed the whitespace in the main branch now, so it should be easier for you to update and reduce the number of changes in the PR.

polymonster avatar May 08 '23 09:05 polymonster

Most crates require running rustfmt and clippy (and the latter coming out clean) before submitting a PR.

The former will alleviate whitespace issues in the future.

I suggest adding both to a git pre-commit hook.

virtualritz avatar May 08 '23 09:05 virtualritz

Most crates require running rustfmt and clippy (and the latter coming out clean) before submitting a PR.

The former will alleviate whitespace issues in the future.

I suggest adding both to a git pre-commit hook.

I am not keen on rustfmt because it messes up some formatting in places so I usually run without.

I regularly run clippy and there are no warnings on this repository.

polymonster avatar May 08 '23 09:05 polymonster

I am not keen on rustfmt because it messes up some formatting in places so I usually run without.

That will make it difficult for people who want to contributing bigger sections of code. They have to guess expected formatting from your code.

There is a reason code formatting is considered a solved issue in the Rust world. Personally, after 30 years of C/C++ it's one of the smaller but important details that makes Rust so enjoyable for me. Just saying.

If you disagree with something cargo fmt would do you can add a rustfmt.toml with your specific constraints to the project root. Not as nice for rustaceans reading the code in your repo as is going with defaults. But definitly better than not running a formatter pre-commit at all.

I just ran it for giggles and the changes are mostly cosmetic. Trailing commas mainly and very few actual wraps/line break/block changes. Except for the matrix stuff, which is expected.

virtualritz avatar May 08 '23 10:05 virtualritz