obsidian-terminal icon indicating copy to clipboard operation
obsidian-terminal copied to clipboard

Integrated Terminal - Three minor problems I am facing in linux.

Open kamrulcodes opened this issue 1 year ago • 4 comments

Prob.1. There is NO Hotkeys for Closing the integrated terminal:

No hotkeys


Prob.2. Exit Command hangs the Integrated terminal:

Exit command hanged


Prob.3. Error comes if I click on the cross icon to exit the integrated terminal. The error message is: Error killing pseudoterminal TypeError: Cannot read properties of undefined (reading 'onRequestRedraw')

kamrulcodes avatar Jan 17 '24 10:01 kamrulcodes

I am facing the same problems on MacOS

danieltomasz avatar Mar 30 '24 13:03 danieltomasz

@kamrulcodes

Prob.1 happens because the terminal has focus; Obsidian isn't in control of the keyboard at that point. If you click away such that the terminal cursor becomes an outline then the standard tab-close shortcut will work (cmd-w for me on macOS).

Prob.2 is pretty standard terminal behaviour. In Terminal on macOS when I hit ctrl-d to exit I get [Process completed] and the window stays open.

Prob.3 is an actual problem. :) I wouldn't care so much if the alert went away, but it sticks around until I click on it.

terminal-error

dcellison avatar Apr 06 '24 22:04 dcellison

@dcellison

I wouldn't care so much if the alert went away, but it sticks around until I click on it.

You can set Error notice timeout (s) in the plugin's settings to any non-zero value, it will disappear after your specified time. A negative value makes it not show up (in actuality, it flashes on screen for an instant).


As for the other issues, it would be nice if those could be solved as well.

Problem 1: On VS Code, i have a shortcut to toggle (show or hide) the integrated terminal, and that shortcut works even when focused on the terminal.

Problem 2: On Gnome, terminals disappear when you hit Ctrl+D. Would be nice if the same could happen within obsidian as well.

RequiemOfSpirit avatar Apr 16 '24 17:04 RequiemOfSpirit

Thank you for that pointer, @RequiemOfSpirit! That's much better. I should have checked the settings. And I agree with your other points. Choice is always good! And it would indeed be better if cmd-w worked whether the terminal had focus or not.

I have to say though, this plugin is just fantastic. I use git to maintain my vaults and I'm very used to the command line for these activities. It bugged me that I had to start up iTerm when I wanted to do my git stuff. This plugin is absolutely ideal for me. I was able to theme it so that it matches my Obsidian theme. It's a joy to use.

dcellison avatar Apr 16 '24 18:04 dcellison

For problem 1, a closing hotkey has been added, which is Command+W on Apple platforms and Ctrl+Shift+W on all other platforms.

For problem 2, this is the intended behavior.

For problem 3, this has been fixed. The error came from the xterm upstrem dependency.

They are available since 3.15.0.

polyipseity avatar Jun 06 '24 12:06 polyipseity