sherlock icon indicating copy to clipboard operation
sherlock copied to clipboard

Updated readme.md

Open vmadman opened this issue 12 years ago • 3 comments

The boolean query example used the query() method, which does not exist. Instead, it should use the queryBuilder() method. Additionally, if you pass a single parameter to must(), should(), or must_not().. then it will be iterated as though it is an array of classes that implement \Sherlock\components\QueryInterface.

Therefore, you cannot pass a Term() or Match() class directly to the must(), should(), or must_not() method as previously shown, but must wrap them in an array or pass multiple classes/queries.

vmadman avatar Jun 22 '13 09:06 vmadman

Sorry if I'm just being dumb here. I suspect that query() was replaced by queryBuilder() at some point?

vmadman avatar Jun 22 '13 09:06 vmadman

Gah, sorry for letting this hang...I'm out of town at the moment. The Readme is definitely wrong (the name did indeed change from query to queryBuilder.

Sounds like a bug for must/should/must_not. I'll investigate when I get home

polyfractal avatar Jun 25 '13 14:06 polyfractal

lgtm.

wangxiaomo avatar Nov 05 '14 01:11 wangxiaomo