Refactor Filters with Null default parameters

Open polyfractal opened this issue 12 years ago • 1 comments

Defaults are hardcoded into filters, basically as best guesses taken from the Perl client. Would be much better to just pass Null and let ES use the internal defaults.

This also reduces maintenance, since ES defaults can change and they will automatically propagate to Sherlock without any changes on our end.

Related to #27

$polyfractal avatar$ Apr 04 '13 13:04 polyfractal

Quick update on this: ES devs say that while Null may work, it is probably not the best solution. There are a few locations (notably "upsert" in the Update operations) where a Null is actually parsed and throws crazy errors.

They advised that parameters only be sent to ES when they are actually set. Which means considerably more work for me :(

$polyfractal avatar$ Apr 09 '13 03:04 polyfractal