athletic icon indicating copy to clipboard operation
athletic copied to clipboard

Published 20 hours ago • verified publisher icon polyfractal

Closing issue #18

Open davidsteinsland opened this issue 11 years ago • 2 comments

Also fixing bug with division by zero in MethodResults.

This will introduce a new method API, so users should update their method signatures before using this patch.

  • classSetUp(array $methods)
  • setUpMethod($method, $iterationsCount)
  • tearDownMethod($method, $iterationsCount)
  • setUp($method, $currentIteration, $iterationsCount)
  • tearDown($method, $iterationsCount)

davidsteinsland avatar Dec 02 '13 23:12 davidsteinsland

Coverage Status

Coverage remained the same when pulling 738c4edf4a5046f8d14819eafcc7f9611d2cc336 on davidsteinsland:feature-callback-arguments into 43fcde883cc511ec0c10f48c2adb685a94a89669 on polyfractal:master.

coveralls avatar Dec 03 '13 00:12 coveralls

Hey, sorry for the delay on this. I was traveling when the PR came in and then just plain forgot about it.

I'm in agreement about making the methods protected, and adding callbacks for pre/post method. I'm a little unsure about the argument changes though.

  • What do you gain by adding the list of methods to class setUp ?
  • Why do you need to know the currentIteration and iterationCount? Wouldn't the setup be the same regardless of which iteration you are on? Otherwise you won't have apples-to-apples comparison.

Not saying I'm against these changes, just trying to get an understanding how they will be used. Thanks!

polyfractal avatar Dec 14 '13 14:12 polyfractal