polyfire-js icon indicating copy to clipboard operation
polyfire-js copied to clipboard

storage customization for react native

Open ryanleecode opened this issue 1 year ago • 1 comments

Right now polyfire is using only local storage. This is a problem in react native since local storage doesn't exist and would be a problem in a web extension context as well. suggestion is to make the storage object generic and allow the user to pass in a storage object as a parameter.

ryanleecode avatar Mar 01 '24 21:03 ryanleecode

You're right, it might be a better way of doing it. I'm pretty sure this is not the only place where it depends on node/browser API though.

We should add tests for theses environment first or we will definitely break them accidentally at some point since we are developing mainly on node/browser.

l11111111111111 avatar Mar 08 '24 08:03 l11111111111111