Nils Weiss comments

Results 122 comments of


                                            Nils Weiss

Added CoAP socket

Thanks for the update. I'll review soon.

Leverage the kernel J1939 implementation for socketcan interfaces?

Hi, I followed your discussion. In the past I did a similar thing for isotp sockets. There is a kernel module available, which I could use for python 3. On...

Add basic implementation of AUTOSAR SecOC

@gpotter2 Ready for review.

Rewrite arch/bpf

Looks good to me.

StrFixedLenField with incomplete packet

In my opinion, the Packet s0 is build as one would expect it in the current implementation. I think it’s not desired to magically add fields to a captured packet....

Use new classifier format for packaging

Thanks for the PR. LGTM

Improve performance with nested `PacketField`s

Thanks for the PR.

Improve performance with nested `PacketField`s

Let's see, how much it breaks ;-)

Improve performance with nested `PacketField`s

Hi, could you please fix the unit tests for your proposal. After that, I would go into a deeper review.

Improve performance with nested `PacketField`s

> > Hi, could you please fix the unit tests for your proposal. After that, I would go into a deeper review. > > I'm on it. > > I've...