persistent icon indicating copy to clipboard operation
persistent copied to clipboard

PersistentVector, transients, polishing

Open tomaskulich opened this issue 10 years ago • 14 comments

Not sure, if you want to merge this.. we did several modifications to the codebase, which you may not like

  • we removed some tests
  • we also removed some Haskell/Scala stuff (such as Option; we rather provide orElse named parameter)
  • given that m is PersistentMap and m[k] is not defined, m[k] throws instead of just returning null. We know, that this is different from Dart standards but we hate the 'null policy' more than we love keeping conventions.

tomaskulich avatar Sep 26 '14 18:09 tomaskulich

That's really huge! It's a pull request I can't really refuse :) I'll have a closer look and maybe modify one thing or two but I think I'll merge it.

Do you want me to add comments to the PR à la code review to suggest some changes and that we iterate together, or do you prefer me to merge it in some branch, modify it myself when/if relevant and then merge with master?

polux avatar Oct 06 '14 07:10 polux

One thing I have to ask you if I want to be able to merge this PR is to sign https://developers.google.com/open-source/cla/individual (there's an electronic version at the end). You, and all the persons who wrote commits in this PR.

The reason is that although this is a personal project, I'm sometimes working on it from work, and so the copyright of this lib belongs to Google. Thus I can't accept patches from people who haven't signed the CLA.

If you and your collaborators agree to sign it, do you want me to contact each of them separately to ask them to sign it, or do you like all sit in the same room in which case you can just ask them?

polux avatar Oct 06 '14 07:10 polux

(Also sorry I missed this pull request, it just got lost in the middle of my github notifications.)

polux avatar Oct 06 '14 07:10 polux

Hi, any news on signing (or not signing) the CLA?

polux avatar Oct 08 '14 09:10 polux

I also can't merge this PR. I'm not a github PR expert but it looks like it's made of a series of commit that lead to a state where the next commit can't apply. Does it correspond to any branch on your side that I could check out? Or alternatively would you mind rebasing these changes on top of my master's head?

polux avatar Oct 10 '14 13:10 polux

@tomaskulich I see from watching on vacuumlab/persistent that you're active on github again. Any news concerning this pull request?

polux avatar Oct 15 '14 09:10 polux

Hello, any news on the CLA?

polux avatar Nov 19 '14 12:11 polux

I'd love to see this in persistent instead of having a diverging vacuum_persistent as well as persistent :)

tosh avatar Nov 26 '14 09:11 tosh

+1

polux avatar Nov 26 '14 10:11 polux

@tomaskulich ping

tosh avatar Feb 21 '15 21:02 tosh

sorry guys, wasn't following this discussion for some time.

@polux : I'll ask the contributors to sign the CLA; I'll let you know, when this happens. Also, I created new PR with the newest changes; you can close this one.

tomaskulich avatar Feb 23 '15 11:02 tomaskulich

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Feb 23 '15 11:02 googlebot

@tomaskulich, awesome! Thanks!

polux avatar Feb 23 '15 11:02 polux

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot avatar May 20 '15 13:05 googlebot