FillableLoaders icon indicating copy to clipboard operation
FillableLoaders copied to clipboard

Renaming rectSize: CGFloat Height of the loader view

Open waltermvp opened this issue 8 years ago • 1 comments

Great framework, it's awesome thank you for sharing. One improvement I would like to suggest is to either rename rectSize to height or actually make it a CGSize. I think making is a CGSize would be more work since it may alter the dimensions, but it should be renamed to height since it can be a little misleading. I'd be happy to make a PR.

waltermvp avatar Jul 20 '16 19:07 waltermvp

Yep, totally agree with you @waltermvp. That legacy things... 😅 Feel free to open a PR!!

polqf avatar Jul 29 '16 16:07 polqf