FlipView icon indicating copy to clipboard operation
FlipView copied to clipboard

Remove Unnecessary Attributes from Manifest

Open commonsguy opened this issue 9 years ago • 2 comments

Your library has an AndroidManifest.file with this content at present:

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.github.polok.flipview">

    <application android:allowBackup="true"
        android:label="@string/app_name"
        android:icon="@drawable/ic_launcher">

    </application>

</manifest>

That will cause build errors for anyone using your library that has attributes that differ from the values that you have defined on the <application> element. Moreover, your library should not be caring about any of those attribute values, as far as I can tell.

If possible, please remove the attributes from the <application> element.

Thanks!

commonsguy avatar May 04 '15 14:05 commonsguy

Hi please remove the ic_launcher icon used in the library no point having that ... its a conflict while using other libraries so please change the icon name or remove it.

ashokslsk avatar Dec 07 '15 10:12 ashokslsk

Done. New version 1.0.1 should be visible in few hours after maven central sync.

polok avatar Dec 08 '15 07:12 polok