ui icon indicating copy to clipboard operation
ui copied to clipboard

Vue 2 & 3 compat

Open jacogr opened this issue 3 years ago • 6 comments

Not sure how that story plays out - when just bumping the deps to 3.x we have issues. If not compatible, need some way to support both.

jacogr avatar Feb 10 '22 05:02 jacogr

Hi @jacogr may I know is there any plan for the upgrade?

tinydjp avatar Mar 20 '22 04:03 tinydjp

It needs to be done, which is why it is logged. :)

PRs for a Vue 3.x version that replaces Vue.extend with createComponent always welcome.

When releasing it it will mean that we will bump to version 2.0 here and probably provide the old/current version as @polkadot/vue2-identicon (so users can use either version, but the default being the one on the latest Vue 3 framework)

jacogr avatar Mar 20 '22 06:03 jacogr

In my experience vue2 and vue3 are different enough to require different repos / branches

dcolley avatar May 23 '22 13:05 dcolley

It is a bit out of my wheelhouse... but if possible, would prefer to have package/vue2-identicon and packages/vue-identicon for vue3. They do operate independently inside packages/*.

If not at all possible.... well, then I guess The 2.x series would be for vue 2 and vue 3 will need a major bump. (It would need a major bump when renaming anyway, so with either option that is a given)

jacogr avatar May 23 '22 13:05 jacogr

It is possible to use Vue-demi

vikiival avatar Jul 20 '22 15:07 vikiival

I would not recommend tracking different versions of vue in your code - that's what branches are for.

dcolley avatar Jul 20 '22 16:07 dcolley

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

polkadot-js-bot avatar Apr 04 '23 05:04 polkadot-js-bot