extension
extension copied to clipboard
polkadot-js
Fixed loading error of dev version on Firefox
Fixed this this problem. You should load the index.html file on Firefox instead of the manifest.json file.
Which version of FF - weirdly enough, the manifest.json works as expected for me.
@Tbaut Which approach do you normally take here?
I have definitely always pointed at the manifest. The Firefox documentation says that any file should work cf https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension#installing
edit: I can confirm that for me, any file works, as per the documentation. I checked some tutorials around and they also mention "any file in the build folder". So I've no strong opinion regarding this PR :shrug: .
Very strange! I've cloned the repo again and executed the same steps (yarn install, yarn build). Now when I load the manifest file of the newly cloned repo I'm having the same problem (file not found), but when I load the manifest file from yesterday it does work. Maybe a Firefox bug? Can someone try the same steps as I did? I've Firefox version 105.0.3.
Which OS? (I am on Mac, Tibaut on Linux … unless he swapped recently)
My FF is also latest, updated this morning.
Which OS? (I am on Mac, Tibaut on Linux … unless he swapped recently)
My FF is also latest, updated this morning.
Latest MacOS. Have you cloned the repository again?
I suggest we stick to the Firefox documentation and change it to "select any file in the packages/extension/build/ folder"
Fresh clone, all good, loads the packages/extension/build/mainfest.json as expected via about:debugging#/runtime/this-firefox.
So it seems very suspect that somewhere this doesn't operate as expected. Unsure as to why.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
