apps
apps copied to clipboard
polkadot-js
Darwinia staking
Hi @jacogr . Could you please help me reviewing this pull request. Thanks for your time.
@jacogr please help me reviewing this pull request. Thanks for your time.
@jacogr I'm so sorry for the inconvenience. Please help me reviewing this pull request. I've made some changes in some package.json files, if you don't merge my code on time, there will still be some conflicts like the ones that have been happening. If that still goes on that means my code will forever be impossible to merge with the master branch. Thank you so much for your time 🙏
I'm aware of the PR - just have a bunch of stuff to dive into atm, so the review queue is a bit behind.
@jacogr I'm so sorry for the incovenience. I've actually made some changes on the package.json file, specifically in packages/page-staking/package.json file. I've noticed that your the version number changes very frequent. This makes it almost impossible for me to merge my code with yours unless you merge my code first before merging any other code. Thank you sooo much
Yes, the packages update on each merge. I would not try to keep on top-of those until approved and then just do a final merge if required.
Having said that, I have not taken a look - but generally, you don't want to mess with package.json, especially not when it comes to staking. You only ever want to add any additional, non-polkadot-js types to apps-config, nowhere else.
@jacogr I have to use bignumber.js for some Darwinia power calculations. Please allow me to add this one package. Thanks in deed
Hi @jacogr .Sorry for the inconvenience, could you please help me reviewing this PR. Thank you so much for your time