apps icon indicating copy to clipboard operation
apps copied to clipboard

Running in production (update ReadMe)

Open Ethereumx opened this issue 2 years ago • 3 comments

I am wondering how to run the app in production as only dev instructions are indicated in the Readme file?

Ethereumx avatar Sep 04 '22 12:09 Ethereumx

  1. yarn build
  2. deploy packages/apps/build

It is not mentioned in the README since it is part of the scripts - and the repo is meant to be deployed to polkadot.js.org. The dev help is there for pull requests. Other usages are mostly on their own.

jacogr avatar Sep 04 '22 13:09 jacogr

Thanks for the clarification. When building (node 16, yarn 1.22) I am getting :

packages/apps-config/src/endpoints/index.ts:9:1 - error TS6192: All imports in import declaration are unused.

9 import { prodChains, prodRelayKusama, prodRelayPolkadot } from './production';
.
.
Found 13 errors.

Error: Command failed: yarn polkadot-exec-tsc --build tsconfig.build.json
    at checkExecSyncError (child_process.js:790:11)
    at Object.execSync (child_process.js:863:15)
    at execSync (file:///home/azakan/polka_explorer/node_modules/@polkadot/dev/scripts/execute.mjs:11:6)
    at main (file:///home/azakan/polka_explorer/node_modules/@polkadot/dev/scripts/polkadot-dev-build-ts.mjs:922:3)
    at file:///home/azakan/polka_explorer/node_modules/@polkadot/dev/scripts/polkadot-dev-build-ts.mjs:956:1
    at ModuleJob.run (internal/modules/esm/module_job.js:183:25)
    at async Loader.import (internal/modules/esm/loader.js:178:24)
    at async Object.loadESM (internal/process/esm_loader.js:68:5)
    at async handleMainPromise (internal/modules/run_main.js:59:12) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 25368,
  stdout: null,
  stderr: null
}

Ethereumx avatar Sep 05 '22 08:09 Ethereumx

It is certainly not unused. Import is here on line 9 -

https://github.com/polkadot-js/apps/blob/bf250faa47486752fe43a748d99f56e71fbc95ec/packages/apps-config/src/endpoints/index.ts#L9

usage is on lines 28, 36 & 62 -

https://github.com/polkadot-js/apps/blob/bf250faa47486752fe43a748d99f56e71fbc95ec/packages/apps-config/src/endpoints/index.ts#L28

https://github.com/polkadot-js/apps/blob/bf250faa47486752fe43a748d99f56e71fbc95ec/packages/apps-config/src/endpoints/index.ts#L36

https://github.com/polkadot-js/apps/blob/bf250faa47486752fe43a748d99f56e71fbc95ec/packages/apps-config/src/endpoints/index.ts#L62

jacogr avatar Sep 05 '22 10:09 jacogr

This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days.

polkadot-js-bot avatar Sep 27 '22 11:09 polkadot-js-bot

Closing.

jacogr avatar Oct 04 '22 05:10 jacogr

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

polkadot-js-bot avatar Oct 11 '22 06:10 polkadot-js-bot