Suggest stakers to use nomination pools

[kianenigma]

...if:

1. the pallet exist
2. for any reason, the they are not receiving staking rewards

in modals such as:

Moreover, this warning should be showed at all times, not only when taking an action. In the Staking -> Accounts page, if pools pallets exist, and if any account is under the aforementioned condition, show the same warning.

All in all, once pools are live on Polkadot, there is the important task of pushing all of the idle nominators to pools, and this starts with such warnings being in place.

[polkadot-js-bot]

This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days.

[jacogr]

Can re-visit when nom pools seems stable.

[kianenigma]

Pools are already in all networks FWIW. We cannot create a pool in Polkadot yet, but I think given the 28 days unbonding period, it is actually sensible to start warning inactive nominators more aggressively now. Moreover, from your code's PoV, everything that's needed is already there.

[kianenigma]

Any chance this will happen?

[kianenigma]

@wirednkod any update from your side on this? would love to see an attempt :)

[wirednkod]

@kianenigma I have started working in this. I would like to ask though if you have in mind specific screens that you think this message should appear. The staking rewards is a bit "tricky" to be identified (at least for me ATM - trying to figure out the way); One other question is: the "not receiving staking rewards" can go under the following categories in my head: a) user is staking but there are no chosen validators from his list - meaning that his is not receiving any rewards ATM; b) user is staking using pools and receiving rewards; Can you elaborate if any of the above falls into the "condition" you mentioned before?

In addition this message should appear only when one (or more) account(s) are not participating in the pools?

[kianenigma]

I have started working in this. I would like to ask though if you have in mind specific screens that you think this message should appear.

in "Staking > Account", or more if @jacogr is onboard.

The staking rewards is a bit "tricky" to be identified (at least for me ATM - trying to figure out the way)...

I don't think this has much to do with staking rewards. Perhaps I should have been more clear on my ask. There exists a function:

minActiveBond(): BN {}

I can help re-implement this, but I am sure it already exists somewhere in the apps, because it is shown in the screenshot above, when you want to nominate/validate.

In "Staking > Account", you have a list of all the accounts that are bonded and their total stake:

const accounts: {stake: BN, stash: AccountId }[];

If, for any account in accounts, its stake is less than minActiveBond(), we show this banner at the top of the page.

---

Te rephrase it, this banner is already displayed in the "setup nominator" page, and it is evaluated against the value that you wish to nominate. I am asking for it to be displayed at all times, against the values that you have already nominated.

Let me know if this is clear 👍

[wirednkod]

Thank you @kianenigma . This makes things clearer

[kianenigma]

In fact, as of https://github.com/paritytech/substrate/issues/12746 / https://github.com/paritytech/substrate/pull/12889:

minActiveBond(): BN {}

is just a simple storage read. @jacogr you can already use this in the existing targets page as well.

[kianenigma]

Still looking forward to this.

[jacogr]

The issue is obviously the "as of" - the apps UI doesn't just have to cater for "as currently deployed on Kusama & Polkadot". It literally caters for all iterations of staking, within reason. (Although that will change a bit with the new in-progress/refreshed staking interfaces, so may use that depending on how the run through with all deployed chains work out.)

[kianenigma]

the apps UI doesn't just have to cater for "as currently deployed on Kusama & Polkadot".

I get your reasoning, but don't find it convincing. This is not just applicable to Polkadot and/or Kusama. Any chain that uses the staking pallet now has an explicit amount that is the minimum needed to earn staking rewards as a nominator (https://github.com/paritytech/substrate/pull/12889/files). If any account, on any chain, has less than this value, they should receive a warning (which they kinda already do). All I am asking extra is: detect if pallet-nomination-pools is present, and if so, amend the warning to point them to this pallet.

This is not so Polkadot specific tbh.