apps icon indicating copy to clipboard operation
apps copied to clipboard

Add extensions dropdown

Open VadimSaveljev opened this issue 2 years ago • 3 comments

Dropdown has two extensions now, we can easily add additional ones in const extensionList Once connected to an extension it will stay connected and load automatically on page load, no additional action is needed from user If extensions are not installed a link will be generated depending on user's browser (right now it's chrome and firefox, by default it will go to chrome)

Screenshot 2022-07-04 at 15 24 10

VadimSaveljev avatar Jul 04 '22 12:07 VadimSaveljev

@jacogr Do we want a dropdown with extensions and let user decide anything? Or that's something I just over-engineered?

The initial problem was: multi popups if you have 2 or more extensions and you enter dapp for the first time

web3enable doesn't allow to go one by one, so I used .enable, with all the logic of taking "supported" extensions from our list + user interaction via dropdown

what if I scratch all of that, and just do a one after another .enable and that's it so let's say you have 2 extensions polka and talisman, you enter dapp for the first time

you get one popup immediately from polka, you press accept to connect, then after that second popup appears now for talisman, same process. Is this what we want? I will also utilize DISALLOW_EXTENSIONS of course, just in case some bad actors appear

VadimSaveljev avatar Jul 07 '22 11:07 VadimSaveljev

I like the idea of having the user decide which extension they want to connect to and import accounts from, and avoid multi pop-ups. The downside I see with the current implementation is that the connect button is a small tab on top that might get lost between other tabs with no call to action to let the user know they need to connect extensions. So the user might get confused why their account is not showing up in the account page if they don't already know or pay attention that they need to connect the extensions. I'd suggest a call to action in the app to let the user know that they need to connect their extnesions. It can be in a form of a modal window with the list of installed extensions, and popup when the user opens the app if they have not connected to any extensions before. Also, on the account page on the top, there can be some info about which extensions are connected so the user would know where the accounts are imported from and be able to connect/disconnect the extensions.

hamidra avatar Jul 07 '22 16:07 hamidra

As discussed elsewhere - the whole idea behind the extension interface is that the user certainly doesn't not have to have another "choose this" interface. It doesn't matter where the accounts come from, the interface should be routable to the correct extension.

jacogr avatar Aug 31 '22 14:08 jacogr

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

polkadot-js-bot avatar Feb 18 '23 20:02 polkadot-js-bot