apps icon indicating copy to clipboard operation
apps copied to clipboard

add derives for transfer

Open gregdhill opened this issue 3 years ago • 6 comments

Signed-off-by: Gregory Hill [email protected]

gregdhill avatar Jan 07 '22 14:01 gregdhill

This pull request introduces 1 alert when merging 203ce603b2469b2f97fb37764c350bf37754b445 into 2eea385777fc9f3128a22eb6cec041efff98ffd6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jan 07 '22 15:01 lgtm-com[bot]

This pull request introduces 1 alert when merging 75fa6cef1266e9c1f0ac88ae6ffee5674eade80e into 2eea385777fc9f3128a22eb6cec041efff98ffd6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jan 07 '22 15:01 lgtm-com[bot]

@jacogr sorry for the tag, not sure if you get notifications from the comments above and I can't mark the PR from 'draft' to 'ready' myself.

Do you have any tips for fixing those two problems?

daniel-savu avatar Jan 19 '22 19:01 daniel-savu

@jacogr would be great to get your feedback on the two questions above. We'd like to resolve those to make it possible to transfer tokens that are implemented via orml-tokens.

nud3l avatar Feb 07 '22 09:02 nud3l

I did comment above, the TL;DR is that you need to use a derive interface with an ApiInterfaceRx signature to make it work.

jacogr avatar Feb 11 '22 09:02 jacogr

Thank you! I'll take a look as soon as I get a chance

daniel-savu avatar Feb 11 '22 09:02 daniel-savu