apps icon indicating copy to clipboard operation
apps copied to clipboard

Apps `Settings > Metadata` breaks

Open al3mart opened this issue 11 months ago • 1 comments

  • I'm submitting a ...

    • [x] Bug report
    • [ ] Feature request
    • [ ] Support request
    • [ ] Other
  • What is the current behavior and expected behavior?

When loading Paseo's app tab Settings > Metadata the application breaks and shows the following error: code length overflow. (116316>18672)

One of the elements that tab shows is color, defined for Paseo here: https://github.com/polkadot-js/apps/blob/69197a4a8f35e9ea42c5c15b0e28469943998f4c/packages/apps-config/src/endpoints/testingRelayPaseo.ts#L67

I wonder if the background image included in there could be the cause of that tab breaking.

Thanks to @ltfschoen for reporting <3

al3mart avatar Mar 05 '24 13:03 al3mart

Thanks for reporting this I was able to reproduce, and will have this checked out shortly

TarikGul avatar Mar 05 '24 13:03 TarikGul

Seems as if this is coming from: https://github.com/polkadot-js/ui/blob/master/packages/react-qr/src/qrcode.ts, and https://github.com/polkadot-js/ui/blob/master/packages/react-qr/src/Display.tsx#L37-L46

I don't know how deep this issue is, but I'll continuing looking into it (Could be a small fix or not). No promises on how fast though, there are things currently higher in the queue.

TarikGul avatar Mar 06 '24 19:03 TarikGul

Metadata would generate something like

{"chainType":"substrate","color":"#FFFFFF","decimals":0,"genesisHash":"","prefix":0,"title":"","unit":"UNIT"}

Where in Paseo's case color is a huge background image. That must be the reason. Unfortunate as it looks great haha. Will try to generate something smaller and resubmit something.

al3mart avatar Mar 08 '24 15:03 al3mart

Metadata would generate something like

{"chainType":"substrate","color":"#FFFFFF","decimals":0,"genesisHash":"","prefix":0,"title":"","unit":"UNIT"}

Where in Paseo's case color is a huge background image. That must be the reason. Unfortunate as it looks great haha. Will try to generate something smaller and resubmit something.

Could definitely be the issue for sure! Let me know if it ends up fixing it, thanks again!

TarikGul avatar Mar 08 '24 15:03 TarikGul

Closed by https://github.com/polkadot-js/apps/pull/10390

al3mart avatar Mar 24 '24 23:03 al3mart

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

polkadot-js-bot avatar Apr 02 '24 17:04 polkadot-js-bot