weechat-matrix icon indicating copy to clipboard operation
weechat-matrix copied to clipboard

Add an option to show display names of users

Open balsoft opened this issue 5 years ago • 8 comments
trafficstars

Currently, weechat-matrix shows "nicks" (I don't know the proper name) of users in the chat. This can get rather unpleasantly confusing in e.g. bridged Telegram rooms: image It would be rather nice to have a configurable option to show display names instead.

balsoft avatar May 12 '20 13:05 balsoft

At this point it's unlikely to be implemented in the script even though a PR has been available for quite some time here https://github.com/poljar/weechat-matrix/pull/28.

The Rust rewrite will support this.

poljar avatar May 12 '20 17:05 poljar

Thank you for your work. If you're working on a rust plugin, does that mean you're going to abandon the python plugin?

caywin25 avatar May 20 '20 12:05 caywin25

Once the rust plugin has feature parity the script will be abandoned, until then the script is in maintenance mode.

poljar avatar May 20 '20 18:05 poljar

That's strange because on some rooms I see the display name, but on other no.

erdnaxeli avatar Nov 06 '20 15:11 erdnaxeli

The script has some hacks and it'll use display names if there are no conflicts, but it's lacking any smart way to deal with the conflicts so it just uses the full user id if there are conflicts.

poljar avatar Nov 06 '20 16:11 poljar

Ok, so maybe I got another issue? In rooms where there is definitively no conflicts, I still don't see the display names.

Here the user Amora does not conflict with anyone. 2020-11-06-174654_820x527_scrot

2020-11-06-174711_849x148_scrot

erdnaxeli avatar Nov 06 '20 16:11 erdnaxeli

So the script will some times use display names but some times the local part of the full user id. So it seems to work as intended even though it's not pretty.

poljar avatar Nov 06 '20 17:11 poljar

Ok so I gave a look to the code and their is only very few cases where the display name is actually used: https://github.com/poljar/weechat-matrix/blob/master/matrix/buffer.py#L1069.

Now I understand why I don't see display name (and I patched the script to show them everywhere).

erdnaxeli avatar Nov 12 '20 08:11 erdnaxeli