weechat-matrix-rs icon indicating copy to clipboard operation
weechat-matrix-rs copied to clipboard

suggestion: why build only debug and not release?

Open cremesk opened this issue 4 years ago • 4 comments

hi, a suggestion... could we please build the plugin as a "release"?

I am building for a shared user system so am concerned with size and performance for the users who do not need debug.

the different is the plugin is so much small with cargo build --release. (more then 300M!)

cargo build:

12:19:40 [email protected] ~/ la /home/creme/.weechat/plugins
.rw-r--r-- 338M creme envs 24 Jul 10:10 matrix.so

and cargo build --release:

15:24:14 [email protected] ~/ la /home/creme/.weechat/plugins
.rw-r--r-- 25M creme envs 24 Jul 13:24 matrix.so

cremesk avatar Jul 24 '21 13:07 cremesk

We aren't building the plugin anywhere? Users can chose how they would like to build it.

Well we are now with every push, but that indeed uses release mode.

poljar avatar Jul 30 '21 17:07 poljar

it is not built anywhere but in the readme.md i only read about a cargo build.

for someone who is not compliant with this it is not obvious that there is a release mode.

https://github.com/poljar/weechat-matrix-rs/blame/master/README.md#L28

cremesk avatar Jul 30 '21 17:07 cremesk

I guess we can switch the README to tell people to build using --release.

poljar avatar Jul 30 '21 18:07 poljar

i think it would be convenient for the "default" user.

you can create a part. "Development" in the readme where the debug mode is used for building. but i guess developers already know that.

cremesk avatar Jul 30 '21 18:07 cremesk