matrix-nio icon indicating copy to clipboard operation
matrix-nio copied to clipboard

Moved callback execution to separate methods.

Open deepadmax opened this issue 11 months ago • 2 comments

I've moved the execution loops of callbacks to separate methods. This is so that the behaviour can be containedly redefined without needing to hard-rewrite all surrounding logic. As it is now, subclassing the client and adding functionality on running the callbacks would entail needing to keep an eye out for any changes to these whole methods upstream, lest an update be missed and either break it or simply not benefit from patches or upgrades to the flow.

deepadmax avatar Mar 17 '24 13:03 deepadmax

Looks like the unit tests weren't too happy with it, but I really do like this concept and I think it's absolutely a move in the right direction

PaarthShah avatar Mar 18 '24 18:03 PaarthShah