Left rooms aren't handeled.
Left rooms didn't receive any love up until now, because of that it's hard to get the events for left rooms.
A new room class should be added for left rooms similarly to the invited rooms. Callbacks should be called for left rooms equally as for invited rooms.
Hey, I know this issue is a bit old but do we still need this feature? If yes, can I try taking a stab at it? @poljar
Yeah this is still missing, it likely wouldn't be too much work, though we do want to convert nio to be powered by the matrix-rust-sdk using PyO3, so this might be wasted effort in the long term.
@poljar I would like to use matrix-nio for one of the GSoC projects and I feel this might help me learn more about the library itself. And also there aren't many good first open issues that I can find in here to contribute to :')
Feel free to tackle it in that case.
@poljar I tried looking at the codebase to get a vague idea of where the room class, room events and callbacks for Left Rooms should be added.
This is what I have gathered so far.
- The Left Room class should be alongside MatrixInvitedRoom in here
- The callbacks should be handled here in base_client.py.
Are
_get_invited_roomand_handle_invited_roomsthe only callbacks for invited_rooms or are there more of them? - Also, I believe we might have to add the Events specific to the Left Rooms something similar to here
Can you please tell me if I'm headed in the right direction?
@poljar I have made a PR on this issue, it would be great if you can review and give me some suggestions on it.