Damir Jelić

Results 351 comments of Damir Jelić

For this to work we'll need to make the API layer smarter. It's a bit dumb that it returns just tuples, so expanding functionality there is not really possible. We'll...

This is quite a hackish way, while we might want to do this to get this quickly, the correct way is to refactor the API to return a `Request` class...

Which nio version is this? The mentioned line doesn't look like this anymore and there have been a couple of fixes regarding this.

State is sadly not persisted in nio, we only persist the E2EE related data and you can chose to save the sync token. If you save your sync token old...

I think this is a bit upside-down. The `ENCRYPTION_ENABLED` flag indicates if encryption support is installed, based on the installed packages it's either true or false. You set it in...

> I set the flag manually to force is off for testing. Before this patch if you couldn't install pycryptodome nio would just crash out while importing dependencies. All I'm...

> @poljar I'm aware that it shouldn't be done that way. That's why I asked what the correct way of making it conditional was. I only set it that way...

> Yes, exactly. I'm unsure how exactly to do that during install. I'm not sure what you mean, do what during install? I don't think we need to do anything...

The way you start adding this is to add a definition [here](https://github.com/poljar/matrix-nio/blob/master/nio/api.py). After that you'll need to write a json schema for the response [here](https://github.com/poljar/matrix-nio/blob/master/nio/schemas.py). A response type will be...

`await client.login(password="password")` returns a response object, if you print that object out you should get the line you're expecting. The lib has a lobgook based logging setup, but it won't...