czml3 icon indicating copy to clipboard operation
czml3 copied to clipboard

Add holes attribute to polygon

Open Stoops-ML opened this issue 9 months ago • 1 comments

  • Add holes attribute to polygon
  • Add PositionListOfLists property
  • Test added for above changes

Stoops-ML avatar May 07 '24 19:05 Stoops-ML

@astrojuanlu any idea why the circleci quality check is failing?

Stoops-ML avatar May 07 '24 19:05 Stoops-ML

Ugh, direct invokations of setup.py on the command line are deprecated and possibly broken...

python setup.py check

Looks like we'll need to get the CI green first (worth doing so in a separate PR)

astrojuanlu avatar May 08 '24 21:05 astrojuanlu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.23%. Comparing base (0477d4a) to head (97a024b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   99.22%   99.23%           
=======================================
  Files          12       12           
  Lines         776      784    +8     
=======================================
+ Hits          770      778    +8     
  Misses          6        6           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 12 '24 13:05 codecov-commenter

This would close https://github.com/poliastro/czml3/issues/96

Stoops-ML avatar May 17 '24 11:05 Stoops-ML

Will require editing some merge conflicts

astrojuanlu avatar May 21 '24 10:05 astrojuanlu