polar icon indicating copy to clipboard operation
polar copied to clipboard

Published 20 hours ago • verified publisher icon polarsource

Private note is required when creating Custom benefit

Open frankie567 opened this issue 1 year ago • 1 comments

This should clearly be optional 🤔

frankie567 avatar Sep 18 '24 09:09 frankie567

Currently, we use a single BenefitCustomProperties schema for both input and output. Problem is, the output has no default value, making it required.

We should introduce a BenefitCustomCreateProperties, like we already do for other benefits, where the note has a None default.

frankie567 avatar Sep 26 '24 07:09 frankie567

@frankie567 i have raised the PR for the same https://github.com/polarsource/polar/pull/4099

nareshNishad avatar Oct 05 '24 12:10 nareshNishad