frostdb
frostdb copied to clipboard
Move operator tests to logic tests
A datadriven logic testing framework was recently added in https://github.com/polarsignals/frostdb/pull/211. Slowly but surely, it would be nice to move our operator tests to this logic testing framework to promote readability and conciseness. #255 does this for the distinct operator. This issue can be closed once the following tests have been moved over:
- [ ] aggregate_test.go
- [ ] filter_test.go
@asubiotto Can you assign this to me?
Sure!
@asubiotto Thanks!!!
hi @bitethecode are you still working on this? if not then i would like to pick this up if that's ok with you
Hi @palash25, are you still interested in working on this? I can reassign to you given that we haven't heard back.
Sorry for being late here. I tried to figure it out but it's too complicated to me. You can unassign!
No problem! Thanks for giving it a shot. @palash25 assigned to you. Feel free to use https://github.com/polarsignals/frostdb/pull/225 as a guide.
thanks for assigning i will look into it this weekend
as i have already submitted 2 PRs, i would like to be unassigned so that someone else can try to convert the remaining go tests
I think there are still some tests to be moved (notably the projection tests in aggregate_test.go
). I believe #302 will likely address this, but reopening to track.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.