frostdb icon indicating copy to clipboard operation
frostdb copied to clipboard

Move operator tests to logic tests

Open asubiotto opened this issue 2 years ago • 3 comments

A datadriven logic testing framework was recently added in https://github.com/polarsignals/frostdb/pull/211. Slowly but surely, it would be nice to move our operator tests to this logic testing framework to promote readability and conciseness. #255 does this for the distinct operator. This issue can be closed once the following tests have been moved over:

  • [ ] aggregate_test.go
  • [ ] filter_test.go

asubiotto avatar Oct 07 '22 13:10 asubiotto

@asubiotto Can you assign this to me?

the-writer-dev avatar Oct 07 '22 20:10 the-writer-dev

Sure!

asubiotto avatar Oct 08 '22 10:10 asubiotto

@asubiotto Thanks!!!

the-writer-dev avatar Oct 10 '22 00:10 the-writer-dev

hi @bitethecode are you still working on this? if not then i would like to pick this up if that's ok with you

palash25 avatar Nov 04 '22 17:11 palash25

Hi @palash25, are you still interested in working on this? I can reassign to you given that we haven't heard back.

asubiotto avatar Nov 21 '22 10:11 asubiotto

Sorry for being late here. I tried to figure it out but it's too complicated to me. You can unassign!

the-writer-dev avatar Nov 21 '22 20:11 the-writer-dev

No problem! Thanks for giving it a shot. @palash25 assigned to you. Feel free to use https://github.com/polarsignals/frostdb/pull/225 as a guide.

asubiotto avatar Nov 22 '22 07:11 asubiotto

thanks for assigning i will look into it this weekend

palash25 avatar Nov 22 '22 07:11 palash25

as i have already submitted 2 PRs, i would like to be unassigned so that someone else can try to convert the remaining go tests

palash25 avatar Dec 02 '22 06:12 palash25

I think there are still some tests to be moved (notably the projection tests in aggregate_test.go). I believe #302 will likely address this, but reopening to track.

asubiotto avatar Mar 06 '23 13:03 asubiotto

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 05 '24 01:01 github-actions[bot]