frostdb icon indicating copy to clipboard operation
frostdb copied to clipboard

Mock out TableProvider and implement a logicalplan.TableReader that returns records directly

Open asubiotto opened this issue 3 years ago • 1 comments

It'd be nice to be able to push arrow records directly into a query plan. Recently, I came across this need during testing, think it would be nice for benchmarking operators with a speed of light scan layer, and also believe it could be useful in other scenarios.

To do this, I think we're going to want to put an interface on top of frostdb.DBTableProvider, where there would be an implementation that would return a normal table through GetTable, and another one that would return a logicalplan.TableReader (already an interface) that would be passed into the DB somehow with a reference to records to return when Iterator is called on it.

asubiotto avatar Sep 30 '22 11:09 asubiotto

Makes sense!

brancz avatar Sep 30 '22 11:09 brancz

Would it be okay if I gave this a shot?

MadhavJivrajani avatar Oct 20 '22 20:10 MadhavJivrajani

@MadhavJivrajani of course!

asubiotto avatar Oct 20 '22 20:10 asubiotto

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 05 '24 01:01 github-actions[bot]