frostdb icon indicating copy to clipboard operation
frostdb copied to clipboard

Make concurrency configurable at runtime

Open metalmatze opened this issue 2 years ago • 6 comments

If we decide to make concurrency configurable at runtime (which we might want to do based on load), I think this will create an unnecessary synchronizer if we have concurrency == 1 for any reason. What do you think of creating a struct with more planning state to make more informed decisions of what to plan? For example, store some sort of notion of whether we have to plan a synchronizer. Maybe it's fine to also check len(phyPlans), but it seems to me like this state complexity will start to balloon. This struct I suggest might also be useful for more planning information (e.g. ordering column guarantees)

Originally posted by @asubiotto in https://github.com/polarsignals/frostdb/pull/202#discussion_r976283462

metalmatze avatar Sep 23 '22 18:09 metalmatze

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 05 '24 01:01 github-actions[bot]

I think @thorfour fixed this recently, right?

asubiotto avatar Jan 05 '24 09:01 asubiotto

I tried, but it ended up being more of a can of worms since our aggregations don't work at concurrency 1. And in testing in prod I ran into additional issues not caught by the unit tests. Needs revisiting.

https://github.com/polarsignals/frostdb/pull/657 for future reference

thorfour avatar Jan 06 '24 18:01 thorfour

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 08 '24 01:02 github-actions[bot]

Removing stale because this is still currently broken.

thorfour avatar Feb 08 '24 21:02 thorfour

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Mar 10 '24 01:03 github-actions[bot]

Closing this in favor of #769

thorfour avatar Mar 28 '24 16:03 thorfour