frostdb icon indicating copy to clipboard operation
frostdb copied to clipboard

Published 20 hours ago • verified publisher icon polarsignals

Remove PrefixedBucket

Open brancz opened this issue 1 year ago • 2 comments

The upstream objstore dependency we use now implements an identical prefixing mechanism (unsurprisingly since we contributed it), so we should get rid of the one in this repository:

https://github.com/polarsignals/frostdb/blob/42eb27a93c4bc694d9ec4848a30c0e5ecdd8efb5/bucket.go

brancz avatar Aug 11 '22 15:08 brancz

Should we change the NewPrefixedBucket func to wrap objstore internally or remove bucket.go altogether and let the caller pass a bucket created from objstore.NewPrefixedBucket?

manojVivek avatar Aug 12 '22 09:08 manojVivek

I would say to replace our implementation entirely with the one from objstore. If you want to pick this up do chat with @asubiotto as he was thinking of tackling this as well.

brancz avatar Aug 12 '22 11:08 brancz