polaris icon indicating copy to clipboard operation
polaris copied to clipboard

[ISSUE #338] support config auth (WIP)

Open chuntaojun opened this issue 1 year ago • 4 comments

Please provide issue(s) of this PR: Fixes #338

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • [x] Configuration
  • [ ] Docs
  • [ ] Installation
  • [ ] Performance and Scalability
  • [ ] Naming
  • [ ] HealthCheck
  • [ ] Test and Release
  • [x] Auth

Please check any characteristics that apply to this pull request.

  • [ ] Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

chuntaojun avatar Sep 03 '22 02:09 chuntaojun

Codecov Report

Merging #623 (be4b5d5) into main (d8d52bb) will increase coverage by 1.85%. The diff coverage is 64.40%.

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   52.33%   54.19%   +1.85%     
==========================================
  Files         164      165       +1     
  Lines       29492    29826     +334     
==========================================
+ Hits        15434    16163     +729     
+ Misses      11961    11518     -443     
- Partials     2097     2145      +48     
Impacted Files Coverage Δ
auth/defaultauth/auth_mgn_core.go 72.22% <ø> (+3.12%) :arrow_up:
auth/defaultauth/group.go 61.61% <ø> (+2.28%) :arrow_up:
auth/defaultauth/user.go 61.87% <ø> (+12.97%) :arrow_up:
auth/defaultauth/user_authability.go 70.96% <ø> (+9.67%) :arrow_up:
cache/namespace.go 76.92% <ø> (ø)
cache/service.go 83.51% <ø> (ø)
common/model/acquire_context.go 87.05% <ø> (ø)
common/model/naming.go 67.44% <ø> (ø)
config/config_file_release_history_authibility.go 100.00% <ø> (ø)
config/config_file_tag.go 62.69% <ø> (ø)
... and 66 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 03 '22 04:09 codecov[bot]

补一下单测

andrewshan avatar Sep 04 '22 08:09 andrewshan

补一下单测

ok

chuntaojun avatar Sep 04 '22 14:09 chuntaojun

待补充相关单元测试,集成测试有另外项目处理

chuntaojun avatar Sep 17 '22 15:09 chuntaojun