r-polars icon indicating copy to clipboard operation
r-polars copied to clipboard

follow-up on deprecation of `stopf`

Open sorhawell opened this issue 1 year ago • 1 comments

It appears that in #468 stopf was a bit hastily replaced with ´stop()` without fixing error msgs.

stopf had a sprintf-like interface to build err msgs, whereas stop as a paste-like interface.

e.g. this does not make sense with stop stop("type of x is not double or integer, it was [%s]", typeof(x))

but should be something like stop("type of x is not double or integer, it was [", typeof(x),"]")

a fast text search on %s reveals about ~30 error messages that need refactoring

sorhawell avatar Dec 03 '23 21:12 sorhawell