r-polars icon indicating copy to clipboard operation
r-polars copied to clipboard

Prevent unnamed non-`Field` elements in `pl$Struct()`

Open etiennebacher opened this issue 10 months ago • 5 comments

Close #1011

Breaking so should be in 0.17.0

etiennebacher avatar Apr 22 '24 07:04 etiennebacher

@eitsupi do you think the next release will be 0.16.4 or 0.17.0? Just wondering since I have a couple of PR that can be merged if the next one is 0.17

etiennebacher avatar May 06 '24 12:05 etiennebacher

I am also worried about this....... The next release of Rust Polars seems going to be pretty huge, and considering that Python was not even released last week, I think we may have trouble incorporating Rust Polars' breaking changes here. So I think it would be better to merge in potentially breaking changes like this and #1078, but probably rarely used, and release 0.16.4. (If we follow semantic versioning, all releases prior to 1.0.0 may contain braking changes, so it is acceptable for 0.16.4 to contain breaking changes)

eitsupi avatar May 06 '24 12:05 eitsupi

I don't think the next rust-polars release will be a big issue (I mean I don't see why it would be more problematic than the previous ones). Also, this PR and #1050 shouldn't have many conflicts with the next release of rust-polars so I'm fine with waiting the rust-polars update before merging those.

etiennebacher avatar May 06 '24 12:05 etiennebacher

Since #1078 is no longer a breaking change, I would like to merge #1078 and release 0.16.4.

eitsupi avatar May 07 '24 15:05 eitsupi

Ah sorry, I understood that you would like to merge this PR but I just misread, back to draft

etiennebacher avatar May 07 '24 17:05 etiennebacher

Can we merge this?

eitsupi avatar May 22 '24 12:05 eitsupi