polars icon indicating copy to clipboard operation
polars copied to clipboard

Published 20 hours ago • verified publisher icon pola-rs

chore(python): Update PyO3

Open ritchie46 opened this issue 3 years ago • 7 comments

ritchie46 avatar Sep 09 '22 12:09 ritchie46

A new #[pyclass(frozen)] option has been added to opt-out of runtime borrow checking by removing the ability to access &mut self for objects owned by Python.

Maybe this helps deal with those pesky clippy warnings (borrow_deref_ref)?

stinodego avatar Sep 09 '22 15:09 stinodego

@ritchie46 Any reason you left this be? I'd be interested in figuring out how to do this migration.

Reference: https://pyo3.rs/latest/migration.html#from-016-to-017

stinodego avatar Nov 21 '22 18:11 stinodego

This was blocked by https://github.com/PyO3/pyo3/issues/2615. I think we can update on next py03 0.18 release.

ritchie46 avatar Nov 22 '22 07:11 ritchie46

PyO3 version 0.18.0 was recently released! So we can see if an upgrade is possible now.

stinodego avatar Jan 19 '23 20:01 stinodego

Hi! I am interested by PyO3. Is there something blocking this PR? Can I help in some way, for example by pursuing it? :slightly_smiling_face:

jjerphan avatar Jan 28 '23 15:01 jjerphan

I believe the blocking issue has been resolved in the latest version of PyO3. Feel free to make a fresh PR with the PyO3 version update!

stinodego avatar Jan 28 '23 15:01 stinodego

Thanks! I have opened https://github.com/pola-rs/polars/pull/6531 to follow-up.

jjerphan avatar Jan 28 '23 17:01 jjerphan

This can be closed, as #6531 was just merged.

stinodego avatar Jan 30 '23 20:01 stinodego