polars icon indicating copy to clipboard operation
polars copied to clipboard

feat(python, rust): implement unique counts for boolean datatype

Open henrikig opened this issue 1 year ago • 4 comments

Closes #16356

henrikig avatar May 29 '24 19:05 henrikig

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.34%. Comparing base (3fe4cfe) to head (38ff3bf).

:exclamation: Current head 38ff3bf differs from pull request most recent head 99e3c02

Please upload reports for the commit 99e3c02 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16588      +/-   ##
==========================================
- Coverage   81.37%   81.34%   -0.04%     
==========================================
  Files        1425     1424       -1     
  Lines      187669   187226     -443     
  Branches     2702     2698       -4     
==========================================
- Hits       152720   152301     -419     
+ Misses      34453    34429      -24     
  Partials      496      496              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 29 '24 19:05 codecov[bot]

CodSpeed Performance Report

Merging #16588 will not alter performance

Comparing henrikig:implement-unique-counts-for-boolean (99e3c02) with main (3fe4cfe)

Summary

✅ 37 untouched benchmarks

codspeed-hq[bot] avatar Jun 04 '24 13:06 codspeed-hq[bot]

@henrikig can you use this trait for determining the unique values.

https://github.com/pola-rs/polars/pull/16765

ritchie46 avatar Jun 06 '24 09:06 ritchie46

@henrikig can you use this trait for determining the unique values.

#16765

@ritchie46 I could make some simplifications in the code when the unique count is 1 (see https://github.com/pola-rs/polars/pull/16588/commits/38ff3bf9ada603747c5b363f2be7e8e32a55c5b6 for details). Were there any other particular use cases for this trait that you thought of? If so its not immediately apparent to me as I think we still need the actual counts and order.

henrikig avatar Jun 06 '24 16:06 henrikig

Closed by https://github.com/pola-rs/polars/pull/25379

henrikig avatar Nov 18 '25 14:11 henrikig