polars icon indicating copy to clipboard operation
polars copied to clipboard

feat(python): Add optional strict parameter to rename

Open Vincenthays opened this issue 1 year ago • 2 comments

Maybe it would be better to implement this on the Rust side to keep the api consistent between Rust and Python. Let me know if you want this, I think I can do it.

Vincenthays avatar Nov 29 '23 11:11 Vincenthays

Yes, this should be implemented in rust.

ritchie46 avatar Nov 29 '23 11:11 ritchie46

There were discussions on wether drop should silently no-op or raise https://github.com/pola-rs/polars/issues/11913. I think the discussion was not concluded. Should this change be part of a larger series of canonization of the no-op vs raise?

Also, you're missing a dot at the end of the strict docstring.

rancomp avatar Nov 30 '23 08:11 rancomp

I'll close this as the PR is somewhat outdated and there is no matching accepted issue. Let's discuss the merits of adding a non-strict rename in an issue first, and if we agree, the PR can be rebased and re-opened.

stinodego avatar Feb 14 '24 14:02 stinodego