polars
polars copied to clipboard
feat(python): Add optional strict parameter to rename
Maybe it would be better to implement this on the Rust side to keep the api consistent between Rust and Python. Let me know if you want this, I think I can do it.
Yes, this should be implemented in rust.
There were discussions on wether drop
should silently no-op or raise
https://github.com/pola-rs/polars/issues/11913. I think the discussion was not concluded. Should this change be part of a larger series of canonization of the no-op vs raise
?
Also, you're missing a dot at the end of the strict
docstring.
I'll close this as the PR is somewhat outdated and there is no matching accepted issue. Let's discuss the merits of adding a non-strict rename in an issue first, and if we agree, the PR can be rebased and re-opened.