pocket
pocket copied to clipboard
[Core] The Watch Begins
Objective
Rename the Fisherman to the Watcher.
Origin Document
https://github.com/pokt-network/pocket/discussions/701#discussioncomment-6598863
Goals
- Make protocol actor naming self-explanatory
- Replace all instances of the fisherman to the watcher so responsibilities are clear
Deliverable
- [ ] Rename all instances of
Fishermen
toWatchers
in https://github.com/pokt-network/pocket - [ ] Rename all instances of
Fishermen
toWatchers
in https://github.com/pokt-network/pocket-network-protocol - [ ] #973
- [x] Be careful with casing (e.g.
Fisherman vs fisherman as it relates to Watcher vs watcher
) and plurality (e.g.fisherman vs fishermen as it relates to watcher vs watchers
)
Non-goals / Non-deliverables
- Any business logic changes
- Updating all threads & conversations related to this
- Updating notion docs
General issue deliverables
- [ ] Update the appropriate CHANGELOG(s)
- [ ] Update any relevant local/global README(s)
- [ ] Update relevant source code tree explanations
- [ ] Add or update any relevant or supporting mermaid diagrams
Testing Methodology
- [ ] Task specific tests or benchmarks:
make ...
- [ ] New tests or benchmarks:
make ...
- [ ] All tests:
make test_all
- [ ] LocalNet: verify a
LocalNet
is still functioning correctly by following the instructions at docs/development/README.md - [ ] k8s LocalNet: verify a
k8s LocalNet
is still functioning correctly by following the instructions here
Creator: @Olshansk Co-Owners: @dylanlott @0xRampey
The renaming will be done in 3 PRs across the 3 repos stated in the deliverables above.
- [ ] #967 at https://github.com/pokt-network/pocket
- [ ] #46 at https://github.com/pokt-network/pocket-network-protocol
- [ ] https://github.com/pokt-foundation/docs/pull/140